Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragon World Game #3219

Closed
wants to merge 5 commits into from
Closed

Dragon World Game #3219

wants to merge 5 commits into from

Conversation

VaibhavS0710
Copy link

PR Description 📜

I have developed a new game using HTML, CSS, and JS
Fixes #3148

Mark the task you have completed ✅

  • [x ] I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • [x ] I have performed a self-review of my own code or work.
  • [x ] I have commented my code, particularly in hard-to-understand areas.
  • [x ] My changes generates no new warnings.
  • [x ] I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • [x ] I have added screenshot for website preview in assets/images
  • [x ] I have added entries for my game in main README.md
  • [x ] I have added README.md in my folder
  • [x ] I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) 📸

Dragon_Gamee

Thank you soo much for contributing to our repository 💗

@kunjgit
Copy link
Owner

kunjgit commented May 13, 2024

Thank you @LordVaibhav ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

@VaibhavS0710
Copy link
Author

Please @kunjgit merge this PR.

@VaibhavS0710
Copy link
Author

@kunjgit please merge this PR.

kunjgit
kunjgit requested changes May 17, 2024
View reviewed changes
Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@VaibhavS0710 you are not following proper guidelines make sure you are looking at documentation once again and folder readme template is for reference so that everyone can have look at base template and use it you should not add your details there !

@VaibhavS0710 VaibhavS0710 changed the title Update FOLDER_README_TEMPLATE.md Dragon World Game May 17, 2024
@VaibhavS0710
Copy link
Author

@kunjgit can you please guide me how I have to change. It will be very helpful for me as a beginner.

@VaibhavS0710 VaibhavS0710 requested a review from kunjgit May 17, 2024 16:57
@VaibhavS0710
Copy link
Author

@kunjgit please review the updated PR.

@VaibhavS0710
Copy link
Author

@kunjgit please verify it if everything is alright

@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

@VaibhavS0710 already the game is there on GameZone even graphics are same and we are not encouraging to adding same game again and again will recommend you to come up with some new ideas !

@kunjgit kunjgit closed this May 19, 2024
@kunjgit
Copy link
Owner

kunjgit commented May 19, 2024

Thank you @VaibhavS0710 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kunjgit kunjgit Awaiting requested review from kunjgit

Assignees
No one assigned
Labels
Pending ⏱️
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[New Game]: Dragon World Game
2 participants
@VaibhavS0710 @kunjgit